TweetFollow Us on Twitter

April 91 - TAspectPicture

TAspectPicture

James Plamondon

The Bed of Procrustes

Greek mythology contains the tale of Procrustes, a wealthy man of Eleusis who was in the habit of taking in travelers for the night. After treating such a traveler to a sumptuous dinner, Procrustes would take him to a room in which there was an iron bed, exactly the right size for a man of average height. Procrustes would then bid his guest to lay down on the bed. If the guest was of average height, then all was well; his sleep would be comfortable and uninterrupted; in the morning he would go on his way.

However, if the guest was shorter than average, Procrustes would place him upon a rack, stretching him out until he was tall enough to fit the bed. Likewise, if the guest were taller than average, Procrustes would decapitate him, to ensure that he, too, fit the bed. The tale of Procrustes was all the more terrible to the ancient Greeks, because of the high value they placed on hospitality.

MacApp often reminds me of Procrustes and his iron bed: so long as one is writing an "average" application-one that uses documents, views, and controls in the manner foreseen by MacApp's designers-all is well. Otherwise, you may have to decapitate your feature list, or extend the MacApp source code, to fit MacApp's iron bed. This limitation is all the more terrible to us, because of the high value object programmers place on code reusability and extensibility.

TAspectPicture

Recently, I found myself strapped to the iron bed when I least expected it. I wanted to do something that appeared to be simple: display a picture in a button-like control. No problem, right? TPicture, in MacApp's UDialog unit, does just that-so I used it. Unfortunately, TPicture (like old Procrustes) distorts its picture as necessary to make it fit in its extent. I needed to maintain the picture's original aspect ratio.

Well, TPicture was still close; surely, I'd just have to override a single routine to get the behavior I wanted. So I looked at the TPicture.Draw() source, and was quite discouraged to see that it called ControlArea() to get the rectangle in which to draw the picture. I had expected to find a routine called something like GetPictureArea(), which would be easy to override. Overriding ControlArea() would have undesirable side-effects. Darn.

OK, no problem; I'd just override Draw(). Whoops! I couldn't do that-calling INHERITED Draw() would then call TPicture.Draw(), drawing the picture twice (differently each time). If I didn't call INHERITED Draw(), my control would not be properly adorned, since adornment is performed by the version of Draw() that is inherited by TPicture. Object Pascal-the language I was using-does not allow me to call a grandparent's version of Draw(), only that of the parent class. Procrustes' iron bed was beckoning.

Well, if there's one thing I've learned in object programming, it's never to write any code you don't have to. If I couldn't inherit the solution to my problem, maybe I could get someone to give it to me. So I described my problem to MacApp.Tech$ as a contest, in which the person supplying the best solution would win. I got a number of excellent responses.

Knepper's solution

Chris Knepper submitted an entry which I classify as an "elegant kludge." This apparent oxymoron describes a solution which relies on the implementation, rather than the interface, of a method (thus, it's a kludge), but which does so in a clever way. Here it is:
PROCEDURE TAspectPicture.Draw(area: Rect); OVERRIDE;
VAR
    saveDataHandle: PicHandle;
BEGIN
    { 1st. draw the picture "correctly" }
    …fill in this blank…

        { 2nd. (the hard part!) call INHERITED Draw }
    { without having TPicture.Draw do anything }
    saveDataHandle := fDataHandle;
    fDataHandle := NIL;
        INHERITED Draw(area);
    fDataHandle := saveDataHandle;
END;  { Draw }

Since TPicture.Draw() just calls INHERITED Draw() if fDataHandle is NIL, this OVERRIDE of TAspectPicture does the trick. TControl.Draw() gets called, the adornments get drawn, and everybody's happy-assuming that the "fill in the blank" part draws the picture in the right place, with the correct aspect ratio.

Eastman's solution

Gordon Eastman's entry was also a kludge, and if it was somewhat less elegant, it was downright cunning. His approach relies on the inner workings of Object Pascal and the MPW Linker. Here it is:
PROCEDURE TControl_Draw(area: Rect; me: TControl); EXTERNAL;
PROCEDURE TAspectPicture.Draw(area: Rect); OVERRIDE;
BEGIN
    { draw picture with correct aspect ratio, then… }
    TControl_Draw(area, SELF);
END;  { Draw }

To quote Eastman's description of his solution, "This is a slime dog trick that relies on how the MPW Pascal compiler and linker work. The linker sees TControl.Draw as TControl_Draw. The compiler generates an extra SELF parameter for methods." I beg to differ; this solution is an affront to slime dogs everywhere. But it works (this week, anyway).

Berdahl's solution

Eric Berdahl found the whole contest laughable, I think; to his mind, it was a undeniable demonstration of the superiority of C++ over Object Pascal. Just to rub it in, he submitted an entry showing how easy it is to implement TAspectPicture in C++, which allows calls to ancestral methods via its scope resolution operator. Here's his solution:
TAspectPicture::Draw(Rect* area) {
//  Compute the rect, then draw the pict, then…
//  Skip TPicture::Draw and go directly to TControl::Draw
TControl::Draw(area);
}  // Draw

The solution does indeed prove C++'s superiority (in this specific ability, at least). It's worth noting again, though, that this whole problem stems from a flaw in the design of the class, not of the language-if MacApp's TPicture class had a GetPictRect() method, there would have been no problem. Good languages are a poor substitute for good design.

The missing solution

No one submitted a solution that I was expecting: changing the MacApp source code to add the method GetPictRect() to TPicture, and modifying TPicture.Draw() to call it. I think of the MacApp source as being like putty-if I don't like it, I change it. So long as I mark my changes well, it's not too hard to move them to the next version of MacApp.

Of course, I always notify the MacApp wizards of my changes, in the hope that they may be incorporated directly into MacApp in the future (thus relieving me of the burden of maintaining my changes with each new MacApp release).

I carefully worded my contest rules to allow this solution. Perhaps everyone else worships the MacApp source as an immutable deity; if so, burn me for a heretic.

Cheung's solution(s!)

Tseung Cheung supplied not just one, but two solutions. The first overrode ControlArea(), since that's the routine called by TPicture.Draw() to calculate the rect in which to draw the control's picture. While it works, this solution has a number of side effects (since ControlArea() is used in a lot of other places).

The second solution used the trick described under Knepper's Solution, above, to bypass TPicture.Draw() by setting fDataHandle to NIL before calling INHERITED Draw(), and then restoring it afterwards. It was the only submission which met all of the contest's "victory conditions," and so it is the winner-and a pretty good one at that. Here it is:

{  CenterRectInRect(): Centre the inner rect within the
outer rect, either horizontally, or vertically, or both }
PROCEDURE CenterRectInRect(VAR inner: Rect; outer: Rect;
                                        horiz, vert: Boolean);
VAR
    innerSize, outerSize:   Point;
BEGIN
    WITH outer DO
        SetPt(outerSize, right - left, bottom - top);

        WITH inner DO
BEGIN
            SetPt(innerSize, right - left, bottom - top);
            IF horiz THEN
                left := outer.left+(outerSize.h-innerSize.h) DIV 2;
            IF vert THEN
                top := outer.top+(outerSize.v-innerSize.v) DIV 2;
            right := left + innerSize.h;
            bottom := top + innerSize.v;
        END;  { with }
END;  { CenterRectInRect}
TYPE
TAspectPicture = OBJECT(TPicture)
    PROCEDURE Draw(area: Rect); OVERRIDE;
END;  { TAspectPicture  }

{   Draw():  Modified from TPicture.Draw to grab the actual
    picture frame, and then centre this frame within the
    TPicture area before drawing it. }
PROCEDURE TAspectPicture.Draw(area: Rect); OVERRIDE;
VAR
    oldState:   SignedByte;
    cntlFrame,
    myPicFrame: Rect;
    saveDataHandle: picHandle;
BEGIN
    IF fDataHandle <> NIL THEN
        BEGIN
            IF fRsrcID <> kNoResource THEN
                LoadResource(Handle(fDataHandle));

                IF fDataHandle^ <> NIL THEN
                BEGIN   { If there's room for the picture… }
                    ControlArea(cntlFrame);
                    myPicFrame := fDataHandle^^.picFrame;
                    CenterRectInRect(myPicFrame, cntlFrame,                                                     TRUE, TRUE);
                    oldState :=                                                             GetHandleBits(Handle(fDataHandle));
                    HNoPurge(Handle(fDataHandle));
                    PenNormal;
                    DrawPicture(fDataHandle, myPicFrame);
                    SetHandleBits(Handle(fDataHandle),                                                          oldState);
                END;  { then }
        END;  { then }

        saveDataHandle := fDataHandle;
    fDataHandle := NIL;
    INHERITED Draw(area);
    fDataHandle := saveDataHandle;
END;  { Draw }

And the moral of this story is…

A number of lessons can be drawn from this example.

First, it would have been better had MacApp's TPicture class contained a GetPictRect() method, which was called by TPicture.Draw() as ControlArea() is now. TPicture.GetPictRect() could have called ControlArea(), so the added method would not have changed the functionality of the code at all.

This is just one example of a problem that runs throughout MacApp: its methods do too much. The MacApp wizards know this, and will admit to feeling deeply ashamed of themselves for it (or will with enough beer in them). They, too, are imperfect people, who write imperfect code-but there are only so many hours in a man-month, and even wizards need sleep.

Second, a sufficiently powerful language can hide a multitude of sins. C++'s scope resolution operator does not remove the problem, but it makes dealing with it much easier. A powerful language can never make up for a bad design, but MacApp cannot reasonably be expected to reach perfection anytime soon, whereas I'm supposed to have shipped yesterday. MacApp 3.0's being in C++ sounds better and better each day (but perhaps I'm having ear trouble).

Third, this example shows that in MacApp development, you can do just about anything, one way or another-or another, or another, or another.

Fourth, and finally, I offered to split the payment for this article with the winner of the contest because I knew that FrameWorks didn't pay anything for its articles. Ha, ha, funny me. A new editor took over FrameWorks, changed the policy-and now I have to fork over some real money to the winner. I out-foxed myself. There's got to be a lesson in here somewhere.

Procrustes revisited

The fact that we were able to get the TAspectPicture class to work-eventually-suggests that the analogy between MacApp and the iron bed of Procrustes is unfair. But I think not; I think it's fair to say that, even after racking our brains, the solutions we came up with were quite a stretch-and that's what Procrustes' iron bed was all about. n
 
AAPL
$107.65
Apple Inc.
+0.67
MSFT
$46.80
Microsoft Corpora
+0.75
GOOG
$557.07
Google Inc.
+6.76

MacTech Search:
Community Search:

Software Updates via MacUpdate

Vitamin-R 2.20b1 - Personal productivity...
Vitamin-R creates the optimal conditions for your brain to work at its best by structuring your work into short bursts of distraction-free, highly focused activity alternating with opportunities for... Read more
Dropbox 2.10.44 - Cloud synchronization...
Dropbox is an application that creates a special Finder folder that automatically syncs online and between your computers. It allows you to both backup files and keep them up-to-date between systems... Read more
Sandvox 2.9.2 - Easily build eye-catchin...
Sandvox is for Mac users who want to create a professional looking website quickly and easily. With Sandvox, you don't need to be a Web genius to build a stylish, feature-rich, standards-compliant... Read more
Cocktail 8.0.1 - General maintenance and...
Cocktail is a general purpose utility for OS X that lets you clean, repair and optimize your Mac. It is a powerful digital toolset that helps hundreds of thousands of Mac users around the world get... Read more
LibreOffice 4.3.3.2 - Free Open Source o...
LibreOffice is an office suite (word processor, spreadsheet, presentations, drawing tool) compatible with other major office suites. The Document Foundation is coordinating development and... Read more
VMware Fusion 7.0.1 - Run Windows apps a...
VMware Fusion allows you to create a Virtual Machine on your Mac and run Windows (including Windows 8.1) and Windows software on your Mac. Run your favorite Windows applications alongside Mac... Read more
OneNote 15.3.2 - Free digital notebook f...
OneNote is your very own digital notebook. With OneNote, you can capture that flash of genius, that moment of inspiration, or that list of errands that's too important to forget. Whether you're at... Read more
Audio Hijack Pro 2.11.4 - Record and enh...
Audio Hijack Pro drastically changes the way you use audio on your computer, giving you the freedom to listen to audio when you want and how you want. Record and enhance any audio with Audio Hijack... Read more
Iridient Developer 3.0.0 beta 3 - Powerf...
Iridient Developer (was RAW Developer) is a powerful image conversion application designed specifically for OS X. Iridient Developer gives advanced photographers total control over every aspect of... Read more
TextWrangler 4.5.11 - Free general purpo...
TextWrangler is the powerful general purpose text editor, and Unix and server administrator's tool. Oh, and also, like the best things in life, it's free. TextWrangler is the "little brother" to... Read more

Latest Forum Discussions

See All

Monster Flash Review
Monster Flash Review By Jordan Minor on October 31st, 2014 Our Rating: :: ALONE IN THE DARKUniversal App - Designed for iPhone and iPad Solid shooting and a surprising amount of spooky tension make Monster Flash a great portable... | Read more »
Retry Review
Retry Review By Rob Thomas on October 31st, 2014 Our Rating: :: SOARING HIGHUniversal App - Designed for iPhone and iPad Flappy who? Let Retry wash all those bad bird-related memories away on a cool retro-flavored flight… right... | Read more »
Dementia: Book of the Dead Review
Dementia: Book of the Dead Review By Lee Hamlet on October 31st, 2014 Our Rating: :: A TOUGH READUniversal App - Designed for iPhone and iPad A witch hunter is sent after a demonic book in the spooky but short-lived Dementia: Book... | Read more »
Card Dungeon, the Semi-Board Game Roguel...
Card Dungeon, the Semi-Board Game Roguelike, Has Been Renovated Posted by Jessica Fisher on October 31st, 2014 [ permalink ] | Read more »
Logitech Protection + Power iPhone5/5S C...
Made by: Logitech Price: $99.99 Hardware/iOS Integration Rating: 3 out of 5 stars Usability Rating: 0.5 out of 5 stars Reuse Value Rating: 0.75 out of 5 stars Build Quality Rating: 0.75 out of 5 stars Overall Rating: 1.25 out of 5 stars | Read more »
This Is Not a Test Goes Free, Permanentl...
This Is Not a Test Goes Free, Permanently Posted by Jessica Fisher on October 31st, 2014 [ permalink ] Universal App - Designed for iPhone and iPad | Read more »
Swap Heroes Review
Swap Heroes Review By Campbell Bird on October 31st, 2014 Our Rating: :: STRATEGIC SWAPPINGUniversal App - Designed for iPhone and iPad Rotate a cast of heroes to fend of waves of monsters in this difficult, puzzle rpg.   | Read more »
Night Sky Pro™ (Reference)
Night Sky Pro™ 3.0.1 Device: iOS Universal Category: Reference Price: $2.99, Version: 3.0.1 (iTunes) Description: Night Sky Pro™Wonder No More™ Night Sky Pro™ is the ultimate stargazing experience. From the creators of the original... | Read more »
Audio Defence : Zombie Arena (Games)
Audio Defence : Zombie Arena 1.0 Device: iOS Universal Category: Games Price: $4.99, Version: 1.0 (iTunes) Description: A zombie shooter audio game. Made from gut-wrenching 3D binaural sound, for a new kind of weird immersion. You... | Read more »
RPG Asdivine Hearts (Games)
RPG Asdivine Hearts 1.1.0 Device: iOS Universal Category: Games Price: $3.99, Version: 1.1.0 (iTunes) Description: SPECIAL PRICE50% OFF (USD 7.99 -> USD 3.99)!!! Travel alongside four companions and a cat in the adventure of a... | Read more »

Price Scanner via MacPrices.net

Apple now offering refurbished 2014 13-inch R...
The Apple Store is now offering Apple Certified Refurbished 2014 13″ Retina MacBook Pros for up to $270 off the cost of new models. An Apple one-year warranty is included with each model, and... Read more
Apple Regains Momentum As Windows Stutters An...
The latest smartphone sales data from Kantar Worldpanel ComTech, for the three months to March 2014, shows Apple performing strongly in the first quarter of the year, with sales bouncing back in... Read more
Worldwide Smartphone Shipments Increase 25.2%...
New smartphone releases and an increased emphasis on emerging markets drove global smartphone shipments above 300 million units for the second consecutive quarter, according to preliminary data from... Read more
Apple now offering refurbished 2014 15-inch M...
The Apple Store is now offering Apple Certified Refurbished 2014 15″ Retina MacBook Pros for up to $400 off the cost of new models. An Apple one-year warranty is included with each model, and... Read more
Apple drops prices on refurbished 2013 Retina...
The Apple Store has dropped prices on 2013 Apple Certified Refurbished 13″ and 15″ Retina MacBook Pros, with Retina models now available starting at $999. Apple’s one-year warranty is standard, and... Read more
New 2.8GHz Mac mini on sale for $949, save $5...
Abt Electronics has the new 2.8GHz Mac mini in stock and on sale for $949.05 including free shipping. Their price is $50 off MSRP, and it’s the lowest price available for this model from any reseller... Read more
Sale! 3.7GHz Quad Core Mac Pro available for...
 B&H Photo has the 3.7GHz Quad Core Mac Pro on sale for $2649 including free shipping plus NY sales tax only. Their price is $350 off MSRP, and it’s the lowest price for this model from any... Read more
Mujjo Steps Up The Game With Refined Touchscr...
Netherlands based Mujjo have just launched their Refined Touchscreen Gloves, stepping up their game. The gloves feature a updated elegant design that takes these knitted gloves to the next level. A... Read more
Sale! Preorder the new 27-inch 5K iMac for $2...
 Abt Electronics has the new 27″ 3.5GHz 5K iMac on sale and available for preorder for $2374.05 including free shipping. Their price is $125 off MSRP, and it’s the lowest price available for this... Read more
Simplex Solutions Inc. Brings Secure Web Surf...
New York based Simplex Solutions Inc. has announced the release and immediate availability of Private Browser 1.0, its revolutionary new secure web browser developed for iPhone, iPad and iPod touch... Read more

Jobs Board

Position Opening at *Apple* - Apple (United...
**Job Summary** Every day, business customers come to the Apple Store to discover what powerful, easy-to-use Apple products can do for them. As a Business Leader, Read more
Sr. Manager, *Apple* Deployment Programs fo...
**Job Summary** Apple is seeking candidates for a new position on the Education Content and Technology team. iPad and Mac is in the hands of millions of teachers and Read more
*Apple* Solutions Consultant (ASC) - Apple I...
…important role that the ASC serves is that of providing an excellent Apple Customer Experience. Responsibilities include: * Promoting Apple products and solutions Read more
*Apple* Solutions Consultant (ASC) - Apple I...
…important role that the ASC serves is that of providing an excellent Apple Customer Experience. Responsibilities include: * Promoting Apple products and solutions Read more
*Apple* Solutions Consultant (ASC) - Apple I...
…important role that the ASC serves is that of providing an excellent Apple Customer Experience. Responsibilities include: * Promoting Apple products and solutions Read more
All contents are Copyright 1984-2011 by Xplain Corporation. All rights reserved. Theme designed by Icreon.